Meh. Code has changed a lot since then and we should just raise them all and see if this is still an issue.
On Mon, Sep 13, 2010 at 05:52:31PM +1000, David Gwynne wrote: > last time i tried this i caused weird issues on people using the > SPI variants of mpi(4). > > this restricts the large number of openings to the SAS or FC mpi(4) > variants, both of which i have succesffully tested myself. > > ok? > > Index: mpi.c > =================================================================== > RCS file: /cvs/src/sys/dev/ic/mpi.c,v > retrieving revision 1.161 > diff -u -p -r1.161 mpi.c > --- mpi.c 13 Sep 2010 07:48:12 -0000 1.161 > +++ mpi.c 13 Sep 2010 07:49:52 -0000 > @@ -339,7 +340,10 @@ mpi_attach(struct mpi_softc *sc) > sc->sc_link.adapter_softc = sc; > sc->sc_link.adapter_target = sc->sc_target; > sc->sc_link.adapter_buswidth = sc->sc_buswidth; > - sc->sc_link.openings = sc->sc_maxcmds / sc->sc_buswidth; > + if (sc->sc_porttype == MPI_PORTFACTS_PORTTYPE_SCSI) > + sc->sc_link.openings = sc->sc_maxcmds / sc->sc_buswidth; > + else > + sc->sc_link.openings = sc->sc_maxcmds; > sc->sc_link.pool = &sc->sc_iopool; > > bzero(&saa, sizeof(saa));
