On Mon, Sep 27, 2010 at 08:28:36PM +0000, Miod Vallat wrote:
> > On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> > <[email protected]> wrote:
> > >        if (pa->pa_slot != PCKBC_AUX_SLOT)
> > > -               return (0);
> > > +               return 0;
> > 
> > "return (x)" is proper KNF.  Please don't undo it.
> 
> Actually, return with braces is old KNF, just like K&R function
> declarations are. Developer taste change over time, and style(9) no
> longer says anything about return statements style.

While there is no explicit mention of this, there is one example
of a return with a return value and that does use the braces so I
can understand where people might get the impression it is needed.

> Miod

        Janjaap van Velthooven
--  ________________________________________
   / __/ /_    / ______/ /_  __/ __/ /___  / 
  / /_  __/___/_/_  /___  / / __/ /___  / /          [email protected]
 /___/_/_________/_____/_/_/_/_______/_/_/        

Reply via email to