> Date: Fri, 26 Nov 2010 07:33:11 -0500
> From: Kenneth R Westerback <[email protected]>
> 
> I can't find a bitmask being used to track i386 CPUs and the amd64
> one was just nuked. So remove misleading comments in both cases.
> 
> Can anyone prove me wrong in the i386 case? Or OK?

There are still bitmasks in the pmap code on both amd64 and i386.

> Index: amd64/include/cpu.h
> ===================================================================
> RCS file: /cvs/src/sys/arch/amd64/include/cpu.h,v
> retrieving revision 1.61
> diff -u -p -r1.61 cpu.h
> --- amd64/include/cpu.h       26 Nov 2010 11:59:40 -0000      1.61
> +++ amd64/include/cpu.h       26 Nov 2010 12:28:07 -0000
> @@ -159,7 +159,7 @@ extern void need_resched(struct cpu_info
>  
>  #if defined(MULTIPROCESSOR)
>  
> -#define MAXCPUS              32      /* bitmask; can be bumped to 64 */
> +#define MAXCPUS              32
>  
>  #define CPU_STARTUP(_ci)     ((_ci)->ci_func->start(_ci))
>  #define CPU_STOP(_ci)                ((_ci)->ci_func->stop(_ci))
> Index: i386/include/cpu.h
> ===================================================================
> RCS file: /cvs/src/sys/arch/i386/include/cpu.h,v
> retrieving revision 1.117
> diff -u -p -r1.117 cpu.h
> --- i386/include/cpu.h        2 Oct 2010 23:13:28 -0000       1.117
> +++ i386/include/cpu.h        26 Nov 2010 12:28:07 -0000
> @@ -183,7 +183,7 @@ extern struct cpu_info *cpu_info_list;
>  
>  #ifdef MULTIPROCESSOR
>  
> -#define MAXCPUS                      32      /* because we use a bitmask */
> +#define MAXCPUS                      32
>  
>  #define CPU_STARTUP(_ci)     ((_ci)->ci_func->start(_ci))
>  #define CPU_STOP(_ci)                ((_ci)->ci_func->stop(_ci))

Reply via email to