Mark Kettenis wrote:
> > From: Marco Peereboom <sl...@peereboom.us>
> >
> > I kind of disagree with you mark and I think that the diff
> > makes sense.
>
> FWIW, I feel too strongly about this.

If you want to check it check it properly. For example use stat to
see if LD_PRELOAD contains an existing file or use file to see if
it's really a library. But checking if LD_PRELOAD only contains an
empty string seems like a non check. Would you also check if it
contained a space or two spaces?

Actually there is no need to check since if the file is not a valid
library the result would be an error which the user has to debug.

Something about giving users enough rope...



# Han

Reply via email to