On Mon, Dec 20, 2010 at 04:44:36PM +0100, Claudio Jeker wrote:
> ip6s_exthdrtoolong is not used at all so why bother keeping it around?
> I guess this was a pre-m_pulldown() counter but is now unused.
>
> --
> :wq Claudio
>
> Index: sys/netinet6/ip6_var.h
> ===================================================================
> RCS file: /cvs/src/sys/netinet6/ip6_var.h,v
> retrieving revision 1.37
> diff -u -p -r1.37 ip6_var.h
> --- sys/netinet6/ip6_var.h 8 Jul 2010 19:42:46 -0000 1.37
> +++ sys/netinet6/ip6_var.h 29 Nov 2010 17:26:21 -0000
> @@ -196,7 +196,6 @@ struct ip6stat {
> u_int64_t ip6s_m2m[32]; /* two or more mbuf */
> u_int64_t ip6s_mext1; /* one ext mbuf */
> u_int64_t ip6s_mext2m; /* two or more ext mbuf */
> - u_int64_t ip6s_exthdrtoolong; /* ext hdr are not continuous */
> u_int64_t ip6s_nogif; /* no match gif found */
> u_int64_t ip6s_toomanyhdr; /* discarded due to too many headers */
>
> Index: usr.bin/netstat/inet6.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/netstat/inet6.c,v
> retrieving revision 1.41
> diff -u -p -r1.41 inet6.c
> --- usr.bin/netstat/inet6.c 21 Oct 2010 10:51:05 -0000 1.41
> +++ usr.bin/netstat/inet6.c 14 Dec 2010 12:34:01 -0000
> @@ -413,8 +413,6 @@ ip6_stats(char *name)
> }
> p(ip6s_mext1, "\t\t%llu one ext mbuf%s\n");
> p(ip6s_mext2m, "\t\t%llu two or more ext mbuf%s\n");
> - p(ip6s_exthdrtoolong,
> - "\t%llu packet%s whose headers are not continuous\n");
> p(ip6s_nogif, "\t%llu tunneling packet%s that can't find gif\n");
> p(ip6s_toomanyhdr,
> "\t%llu packet%s discarded due to too many headers\n");
>
Always reporting 0 or garbage does seem silly. ok krw@ for what it's
worth.
.... Ken
