> Comments?
Looks quite fine, but I noticed there are no NULL checks for the
newly allocated strings. Aborting a command gracefully might be
better than crashing, should anyone ever be unfortunate enough
to hit this.
Also:
> @@ -415,8 +421,11 @@
> ewprintf("Directory name too long");
> return (FALSE);
> }
> - if ((bufp = eread("Rename %s to: ", toname,
> - sizeof(toname), EFDEF | EFNEW | EFCR, basename(frname))) == NULL)
> + s = xbasename(frname);
> + bufp = eread("Rename %s to: ", toname,
> + sizeof(toname), EFDEF | EFNEW | EFCR, basename(frname));
^^^^^^^^^^^^^^^^
