You should reuse the CENIX OUI already defined in
miidevs rather than add another value for it.

What makes you think it is 79C873 specifically?

Does the device attach to a ehci or uhci uhub?
It seems rather strange to see udav devices still
about unless it is one of davicom's newer usb2
based chips.

On Sun, Feb 13, 2011 at 03:19:51PM -0500, Loganaden Velvindron wrote:
> Hi, This USB unit is shipped with some Apple Macbooks.
> 
> Closer inspections shows it's just a udav(4), with an
> amphy(4) clone.
> 
> I'm sending this mail through this USB adapter with my 
> diff.
> 
> Index: src/sys/dev/mii/amphy.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/mii/amphy.c,v
> retrieving revision 1.18
> diff -u -r1.18 amphy.c
> --- src/sys/dev/mii/amphy.c   8 Sep 2008 07:38:33 -0000       1.18
> +++ src/sys/dev/mii/amphy.c   13 Feb 2011 20:13:54 -0000
> @@ -85,7 +85,8 @@
>         MII_STR_DAVICOM_DM9601 },
>       { MII_OUI_xxALTIMA,             MII_MODEL_AMD_79C875phy,
>         MII_STR_AMD_79C875phy },
> -
> +     { MII_OUI_APPLE,                MII_MODEL_APPLE_79C873,
> +       MII_STR_APPLE_79C873 },
>       { 0,                            0,
>         NULL },
>  };
> 
> Index: src/sys/dev/mii/miidevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/mii/miidevs,v
> retrieving revision 1.116
> diff -u -r1.116 miidevs
> --- src/sys/dev/mii/miidevs   21 Jan 2011 09:46:13 -0000      1.116
> +++ src/sys/dev/mii/miidevs   13 Feb 2011 20:13:31 -0000
> @@ -71,6 +71,7 @@
>  oui PLESSEYSEMI                      0x046b40        Plessey Semi.
>  oui NATSEMI                  0x080017        National Semi.
>  oui TI                               0x080028        Texas Instruments
> +oui APPLE                    0x000749        Apple Inc.
>  
>  /* in the 79c873, AMD uses another OUI (which matches Davicom!) */
>  oui xxALTIMA                 0x000895        Altima
> @@ -113,6 +114,7 @@
>  model xxAMD 79C873           0x0000  Am79C873 10/100 PHY
>  model AMD 79C875phy          0x0014  Am79C875 quad PHY
>  model AMD 79C873phy          0x0036  Am79C873 internal PHY
> +model APPLE 79C873           0x0001  Am79C873 10/100 PHY
>  
>  /* Agere PHYs */
>  model AGERE ET1011           0x0004  ET1011 10/100/1000baseT PHY

Reply via email to