On 2011/03/16 19:01, Christiano F. Haesbaert wrote: > On 10 March 2011 19:31, Christiano F. Haesbaert <[email protected]> > wrote: > > Hi, the following displays rejected icmp echo requests sent to bcast/mcast. > > > > Index: inet.c > > =================================================================== > > RCS file: /cvs/src/usr.bin/netstat/inet.c,v > > retrieving revision 1.115 > > diff -d -u -p -w -r1.115 inet.c > > --- inet.c 2 Mar 2011 21:51:14 -0000 1.115 > > +++ inet.c 10 Mar 2011 22:31:16 -0000 > > @@ -587,6 +587,8 @@ icmp_stats(char *name) > > p(icps_tooshort, "\t%lu message%s < minimum length\n"); > > p(icps_checksum, "\t%lu bad checksum%s\n"); > > p(icps_badlen, "\t%lu message%s with bad length\n"); > > + p(icps_bmcastecho, "\t%lu echo message%s to broadcast/multicast " > > + "rejected\n"); > > for (first = 1, i = 0; i < ICMP_MAXTYPE + 1; i++) > > if (icmpstat.icps_inhist[i] != 0) { > > if (first) { > > > > > > Any feedback on this ? >
It's ok with me, I'll probably commit it tomorrow unless there are objections or someone beats me to it. I considered removing the word 'rejected' to make it better fit the text style of other lines, but that would be incorrect as the counter is not incremented if net.inet.icmp.bmcastecho == 1.
