Hopefully one day adduser(8), will have "use warnings;" added to it.
However, when that glorious does come, any existing adduser.conf files
created by adduser(8) will generate warnings because the template
adduser(8) uses to create adduser.conf has some unquoted strings.
This diff allows any future adduser.conf files to NOT create warnings,
if/when "use warnings;" is added.
ok?
-mark
Index: adduser.perl
===================================================================
RCS file: /cvs/src/usr.sbin/adduser/adduser.perl,v
retrieving revision 1.55
diff -u -p -r1.55 adduser.perl
--- adduser.perl 12 May 2011 05:13:42 -0000 1.55
+++ adduser.perl 12 May 2011 05:20:08 -0000
@@ -1580,6 +1580,7 @@ sub config_write {
# Note: adduser reads *and* writes this file.
# You may change values, but don't add new things before the
# line ``$do_not_delete''
+# Also, unquoted strings may cause warnings.
#
# verbose = [0-2]
@@ -1587,7 +1588,7 @@ verbose = $verbose
# Get new password for new users
# defaultpasswd = yes | no
-defaultpasswd = $defaultpasswd
+defaultpasswd = "$defaultpasswd"
# Default encryption method for user passwords
# Methods are all those listed in login.conf(5)
@@ -1623,14 +1624,14 @@ shellpref = ($shpref)
defaultshell = "$defaultshell"
# defaultgroup ('USER' for same as username or any other valid group)
-defaultgroup = $defaultgroup
+defaultgroup = "$defaultgroup"
# new users get this uid
uid_start = $uid_start
uid_end = $uid_end
# default login.conf(5) login class
-defaultclass = $defaultclass
+defaultclass = "$defaultclass"
# login classes available from login.conf(5)
# login_classes = ('default', 'daemon', 'staff')
