On Fri, May 13, 2011 at 11:57:37AM +0200, Mike Belopuhov wrote: > On Fri, May 13, 2011 at 11:50 AM, Otto Moerbeek <[email protected]> wrote: > > On Fri, May 13, 2011 at 11:39:01AM +0200, Mike Belopuhov wrote: > > > >> On Fri, May 13, 2011 at 11:26 AM, Mark Kettenis <[email protected]> > wrote: > >> >> From: Vadim Zhukov <[email protected]> > >> >> Date: Fri, 13 May 2011 13:10:10 +0400 > >> >> > >> >> Hello all. > >> >> > >> >> Looks like there is a typo in ioctl number... > >> > > >> > What makes you think this is a typo? > >> > > >> > >> there are two ioctls with the same command number: > >> > >> #define BIOCDISCIPLINE _IOWR('B', 40, struct bioc_discipline) > >> #define BIOCINSTALLBOOT _IOWR('B', 40, struct bioc_installboot) > > > > Only if the two structs happen to have the same size they will clash. > > > > indeed. but was it intentional to have them both set to 40 > in the first place?
I'll venture and guess this was unintended. We should make it unique and I am ok with the original diff that makes it 41. > > > -Otto
