On Fri, May 27, 2011 at 01:22:24PM +0200, Reyk Floeter wrote: > On Fri, May 27, 2011 at 11:11:37AM +0200, Michal Mazurek wrote: > > Add listening on interface groups for dhcpd, from gilles@' smtpd. > > the dhcpd bit is interesting. > > > Add static to is_if_in_group in smtpd and relayd. > > i normally don't use static functions in relayd. > > > Fix whitespaces in is_if_in_group in smtpd and relayd. > > > > please also don't send diffs as simple as whitespace/knf to the lists; > this is done by hackers occasionally when we are bored or need to keep > up our commit rate... > > > I didn't write a diff for dhcpd's manpage. > > > > you should write a new diff for dhcpd only that also includes the > manpage bits. > > reyk
+1 on all comments. .... Ken
