On 2011/06/19 14:46, Mark Kettenis wrote:
> > Date: Sun, 19 Jun 2011 12:52:43 +0100
> > From: Stuart Henderson <s...@spacehopper.org>
> > 
> > some different versions of MII devices print identical strings
> > when they attach, this diff makes them unique.  ok?
> 
> I think this is ugly.  Unless there is a pressing need to distinguish
> these in dmesg, I'd urge you not to do this.

I was particularly interested in F1 to see if Brad's recent change
that was meant to fix negotiation on gig ports in atphy(4) was being
triggered on my Eee (it's done for F1 and not F1_7) and noticed that
it was already done like this for Marvell 88E1000.

I thought it may be useful in some other cases but there's no real
pressing need.

Reply via email to