On Sat, Jul 09, 2011 at 06:51:04AM +0100, Stuart Henderson wrote: > On 2011/07/08 20:51, Henning Brauer wrote: > > CVSROOT: /cvs > > Module name: src > > Changes by: [email protected] 2011/07/08 20:51:18 > > > > Modified files: > > usr.sbin/bgpd : rde.c session.c > > > > Log message: > > remove that rlimit code, rc.d and login classes do it much betterer these > > days. screaming bob ok claudio > > > > Similar code is in a few other places, if it's going from bgpd it > should be zapped there too. Should we add login.conf sections for > bgpd, ftp-proxy, inetd, relayd, smtpd and spamd, or just bump > the default openfiles-cur for daemon to 512 or something and > maybe add sections for a few daemons that might still have > trouble with 512 (partly to help with the limits, and partly > to show people how it's done)?
At least spamd does set the openfiles-cur based on the maximum number of connections a users specifies. That code is OK. Daemons setting the limit to infinity on the otherhands are not. > Index: login.conf.in > =================================================================== > RCS file: /cvs/src/etc/login.conf.in,v > retrieving revision 1.3 > diff -u -p -r1.3 login.conf.in > --- login.conf.in 17 Dec 2010 05:33:06 -0000 1.3 > +++ login.conf.in 9 Jul 2011 05:50:02 -0000 > @@ -60,7 +60,7 @@ daemon:\ > :ignorenologin:\ > :datasize=infinity:\ > :maxproc=infinity:\ > - :openfiles-cur=128:\ > + :openfiles-cur=512:\ > :stacksize-cur=8M:\ > :localcipher=blowfish,@ROOT_BLOWFISH_RNDS@:\ > :tc=default: > @@ -84,3 +84,14 @@ authpf:\ > :welcome=/etc/motd.authpf:\ > :shell=/usr/sbin/authpf:\ > :tc=default: > + > +# > +# Some daemons may need additional file handles > +# > +relayd:\ > + :openfiles-cur=infinity:\ > + :tc=daemon: > + > +spamd:\ > + :openfiles-cur=infinity:\ > + :tc=daemon: > -- :wq Claudio
