On Sat, Jul 09, 2011 at 09:49:47AM +0200, Otto Moerbeek wrote:
> Hi,
>
> kdump -m 0 does not do what you'd expect. Fix that, and do not print
> "" for empty strings.
>
> -Otto
On second thought I think this diff is better. It'll still print ""
for an empty string if maxdata > 0.
-Otto
Index: kdump.c
===================================================================
RCS file: /cvs/src/usr.bin/kdump/kdump.c,v
retrieving revision 1.57
diff -u -p -r1.57 kdump.c
--- kdump.c 9 Jul 2011 07:22:05 -0000 1.57
+++ kdump.c 9 Jul 2011 14:59:03 -0000
@@ -63,7 +63,7 @@
#include "kdump_subr.h"
#include "extern.h"
-int timestamp, decimal, iohex, fancy = 1, tail, maxdata, resolv;
+int timestamp, decimal, iohex, fancy = 1, tail, maxdata = INT_MAX, resolv;
char *tracefile = DEF_TRACEFILE;
struct ktr_header ktr_header;
pid_t pid = -1;
@@ -774,7 +774,9 @@ ktrgenio(struct ktr_genio *ktr, size_t l
}
printf("fd %d %s %zu bytes\n", ktr->ktr_fd,
ktr->ktr_rw == UIO_READ ? "read" : "wrote", datalen);
- if (maxdata && datalen > maxdata)
+ if (maxdata == 0)
+ return;
+ if (datalen > maxdata)
datalen = maxdata;
if (iohex && !datalen)
return;
