On Sun, Nov 13, 2011 at 12:32:51AM -0500, Lawrence Teo wrote:
> The diff tweaks the ipsec.conf(5) manpage to refer to the outgoing NAT
> section explicitly when discussing srcnat. This helps the reader know
> exactly which section to look at for further details.
> 
> Lawrence
> 
> 

fixed, thanks.

for the record i should say that i was about to reply that there is a
balance between clarity (your diff provides it) and brevity (but not
this). since the next /srcnat gets you to the correct section, i was
about to reject the diff. but looking at the rest of the page, every
other "see below" gives the exact section, so i went with that approach.

i do think we should probably use less Sx in general though.

jmc

> Index: ipsec.conf.5
> ===================================================================
> RCS file: /cvs/src/sbin/ipsecctl/ipsec.conf.5,v
> retrieving revision 1.135
> diff -u -p -r1.135 ipsec.conf.5
> --- ipsec.conf.5      3 Sep 2011 22:59:08 -0000       1.135
> +++ ipsec.conf.5      13 Nov 2011 05:24:45 -0000
> @@ -263,7 +263,8 @@ argument specifies a fictional source ID
>  the
>  .Ar srcnat
>  parameter can be used to specify the actual source address.
> -This can be used in outgoing NAT/BINAT scenarios as described below.
> +This can be used in outgoing NAT/BINAT scenarios as described below in
> +.Sx OUTGOING NETWORK ADDRESS TRANSLATION .
>  Host addresses are parsed as type
>  .Dq IPV4_ADDR ;
>  adding the suffix /32 will change the type to

Reply via email to