On Fri, Jan 13, 2012 at 11:01:43AM -0300, Fernando Gont wrote: > On 01/12/2012 04:04 PM, Alexander Bluhm wrote: > > I have reconsidered it and drop the fragments immediately. The > > packet to be reassembled will be dropped after timeout. > > Sorry: immediately, or after a timeout?
We have a list of fragments that belong to one packet. When an incomming fragment overlaps any fragment in the list, all fragments are dropped immediately and the list gets empty. But the state with the empty list will be kept until timeout. > > - If the fr_queue is empty, we had overlapping fragments, don't add > > new ones. > > Not sure what this means. When more fragments arrive and the list is empty, there was an overlap before. Then the new fragment is dropped. This state will exist until timeout. > P.S.: Will try your patch this weekend. Thanks. I have already commited it, so you can use -current. It is probably not in the snapshots yet. More testing is always good. bluhm
