On 04/21/12 19:33, Jason McIntyre wrote:
> 
> any dissention, or inaccuracies?
> 
> jmc
> 
> Index: pf.conf.5
> ===================================================================
> RCS file: /cvs/src/share/man/man5/pf.conf.5,v
> retrieving revision 1.513
> diff -u -r1.513 pf.conf.5
> --- pf.conf.5 31 Jan 2012 07:46:32 -0000      1.513
> +++ pf.conf.5 21 Apr 2012 17:32:13 -0000
> @@ -72,14 +72,17 @@
>  .Pp
>  Additional configuration files can be included with the
>  .Ic include
> -keyword, for example:
> +keyword.
> +Note that argument names not beginning with a letter, digit, or underscore
> +must be quoted.
> +For example:
>  .Bd -literal -offset indent
>  include "/etc/pf/sub.filter.conf"
>  .Ed
>  .Pp

Keywords need to be quoted, too.
This does not work (syntax error)
    include tag
while this works:
    include "tag"

What got me thinking about this: Is that sentence supposed to describe
quoting rules for the "include" keyword (I'm reading it that way) or
should it apply to the whole pf.conf grammar?

I think it should apply to the whole grammar:
This does not work (syntax error)
    pass in tag tag
    pass in tag /foo
while this works:
    pass in tag "tag"
    pass in tag "/foo"

One other thing: Are you aiming for an exhaustive list of things that
need to quoted? For example at first I thought that spaces need to be
quoted, it turns out that assumption was wrong, this works:
    pass in tag foo bar

I don't know if your sentence + something about keywords would be an
exhaustive list.

florian

Reply via email to