Now that we have a default set of CDIAGFLAGS, would it make sense to add this? It doesn't affect kernel builds, but at least helps pick up problems creeping in to userland.
OK? Index: bsd.own.mk =================================================================== RCS file: /cvs/src/share/mk/bsd.own.mk,v retrieving revision 1.119 diff -u -p -r1.119 bsd.own.mk --- bsd.own.mk 17 Aug 2012 17:09:43 -0000 1.119 +++ bsd.own.mk 20 Aug 2012 09:08:17 -0000 @@ -105,6 +105,9 @@ LOCALEMODE?= ${NONBINMODE} CDIAGFLAGS= -Wall -Wpointer-arith -Wuninitialized -Wstrict-prototypes CDIAGFLAGS+= -Wmissing-prototypes -Wunused -Wsign-compare -Wbounded CDIAGFLAGS+= -Wshadow +. if ${COMPILER_VERSION} == "gcc4" +CDIAGFLAGS+= -Wdeclaration-after-statement +. endif .endif # Shared files for system gnu configure, not used yet