> Date: Mon, 20 Aug 2012 10:10:39 +0200 > From: Marc Espie <[email protected]> > > since you have -Werror in your CFLAGS, sndio fails a build with > WARNINGS=Yes... > > The following patch fixes things. > - don't shadow libc rindex.
Must admit that it's getting a bit of a personal crusade, but I feel quite strongly that -Wshadow in its current implementation is useless because it whines about local variables shadowing global functions. That really never ever signals a programming problem. And it introduces a significant issue because whenever we add a new function to one of our headers we suddenly get warnings just because somewhere in the tree we have code that happens to use a local variable with the same name. And really, isn't it retarded that I can't have a local variable named "index" just because I include <string.h>?
