On 2012/09/22 13:29, Camiel Dobbelaar wrote: > On 21-9-2012 23:40, Stuart Henderson wrote: > > $ ifconfig vr0 hwfeatures|head -2 > > vr0: flags=8b43<UP,BROADCAST,RUNNING,PROMISC,ALLMULTI,SIMPLEX,MULTICAST> > > mtu 1500 > > hwfeatures=8017<CSUM_IPv4,CSUM_TCPv4,CSUM_UDPv4,VLAN_MTU,WOL> > > > > No problems noticed yet. (this is running i386). > > > > $ ifconfig vlan6 hwfeatures|head -2 > > vlan6: flags=8943<UP,BROADCAST,RUNNING,PROMISC,SIMPLEX,MULTICAST> mtu 1500 > > hwfeatures=0<> > > > > Is it right/expected that CSUM_* aren't propagated to the vlan ifaces? > > It is correct. vr(4) does not have VLAN_HWTAGGING. > > The comment in the code explains it:
Aha. iirc some vr hardware does support hw tags, so maybe we want to look at enabling that, though also iirc there were issues with some of the offloading on vr actually reducing performance in some cases, I don't remember the details at the moment though, that may have been csum not tags.. > > /* > > * If the parent interface can do hardware-assisted > > * VLAN encapsulation, then propagate its hardware- > > * assisted checksumming flags. > > * > > * If the card cannot handle hardware tagging, it cannot > > * possibly compute the correct checksums for tagged packets. > > * > > * This brings up another possibility, do cards exist which > > * have all of these capabilities but cannot utilize them together? > > */ > > if (p->if_capabilities & IFCAP_VLAN_HWTAGGING) > > ifv->ifv_if.if_capabilities = p->if_capabilities & > > IFCAP_CSUM_MASK;
