On 09/23/12 22:24, Ted Unangst wrote:
On Sat, Sep 22, 2012 at 14:01, Theo de Raadt wrote:
Only concern I have is whether #include <machine/cpu.h> could have
side-effects on architectures I don't know of (which, admittedly, is
quite a few).

it is a bad idea to pull machine/ header files.

I was going to agree, but that's how sbin/sysctl gets at these
defines.  So it's that or sys/sysctl.h needs to pull it in itself.

FWIW, this is essentially the same as -r1.32 of sbin/reboot/reboot.c which I committed at g2k12.

Reply via email to