On Fri, Nov 23, 2012 at 5:16 PM, Reyk Floeter <[email protected]> wrote:
> On Fri, Nov 23, 2012 at 04:04:20PM +0000, Stuart Henderson wrote:
>> This adds an ioctl to retrieve if_hardmtu, and adds code to
>> display it via ifconfig hwfeatures.
>>
>> $ ifconfig em0 hwfeatures
>> em0: flags=8b43<UP,BROADCAST,RUNNING,PROMISC,ALLMULTI,SIMPLEX,MULTICAST> mtu 
>> 1500
>>       hwfeatures=30<VLAN_MTU,VLAN_HWTAGGING> hardmtu=16110
>>       lladdr f0:de:f1:f9:a7:52
>>       priority: 0
>>       trunk: trunkdev trunk0
>>       media: Ethernet autoselect (100baseTX full-duplex,rxpause,txpause)
>>       status: active
>>
>> Added bonus, mention a few other existing ioctls in netintro(4).
>>
>> Any comments/bikeshedding about display format/OKs?
>>
>
> I would replace the "=" after hardmtu with a single whitespace to
> follow the common ifconfig style.  The "=" is only used for flags-type
> fields.
>
> The diff looks fine to me.
>

funny enough there's no equal sign in the original diff (:
ok mikeb

Reply via email to