On Tue, Dec 25, 2012 at 6:55 AM, Vadim Zhukov <persg...@gmail.com> wrote: > A small nit in fsck_ffs/dir.c. A few lines above (size_t) cast is > used, but here it's missing. ... > - if (memcmp(dirp->d_name, idesc->id_name, (int)dirp->d_namlen + 1)) > + if (memcmp(dirp->d_name, idesc->id_name, (size_t)dirp->d_namlen + 1))
(int) is certainly wrong, but I think those casts date back to 16bit ints. Now, for either of those casts to have any effect at all, d_namlen would have to be a signed 32 (or 64) bit type. Maybe we should delete them instead. otto? Philip
