On Fri, Feb 1, 2013 at 10:17 PM, Stuart Henderson <s...@spacehopper.org>wrote:

> In gmane.os.openbsd.misc, Mattieu Baptiste wrote:
> > Hi,
> >
> > I'm testing npppd with pppx(4).
> >
> > As i'm understanding npppd, a new pppx(4) interface is created for every
> > new session. Thus, new /dev/pppxN nodes must be created for the sessions
> > that we intend to have.
> >
> > But at this point, filtering with PF needs special handling for every
> > pppx(4) interface. How about adding these interfaces to a "pppx"
> interface
> > group, by adding the if_addgroup() call ?
> >
> > What do you think ?
>
> This makes sense to me, and the diff below seems to work:
>


Hello Stuart,

Thanks, this works as expected.



>
> Index: if_pppx.c
> ===================================================================
> RCS file: /cvs/src/sys/net/if_pppx.c,v
> retrieving revision 1.15
> diff -u -p -r1.15 if_pppx.c
> --- if_pppx.c   19 Sep 2012 17:50:17 -0000      1.15
> +++ if_pppx.c   1 Feb 2013 21:15:47 -0000
> @@ -874,6 +874,7 @@ pppx_add_session(struct pppx_dev *pxd, s
>                 pipex_timer_start();
>
>         if_attach(ifp);
> +       if_addgroup(ifp, "pppx");
>         if_alloc_sadl(ifp);
>
>  #if NBPFILTER > 0
>
>


-- 
Mattieu Baptiste
"/earth is 102% full ... please delete anyone you can."

Reply via email to