On Thu, Mar 14, 2013 at 6:48 PM, Ted Unangst <t...@tedunangst.com> wrote: > On Thu, Mar 14, 2013 at 17:24, Antoine Jacoutot wrote: >> On Thu, Mar 14, 2013 at 11:41:52AM -0400, Ted Unangst wrote: >>> On Thu, Mar 14, 2013 at 14:30, Antoine Jacoutot wrote: >>> >>> > FYI I am seeing a somehow similar crash when using sysutils/bacula (both >>> > 5.2 and 5.3). >>> > It is 100% reproducible on my setup. Obviously painful since it means I >>> > cannot run backups anymore... >>> >>> The following is brought to you without testing or warranty. It did >>> compile at least once though. >> >> Awesome, thanks! I ran several batches of concurrent backups and I cannot >> reproduce the crash anymore :-) >> I'm going to run with that patch for the time being... if I spot any >> regression, I'll let you know. > > Couple fixes. In some error cases, there are early returns I didn't > notice before. Fixed diff below, though I don't think a correct > program should be affected. > > Alexey, sorry, I didn't get to your final diff before. It's very > similar to the diff below, so you were on the right track. One thing > that's different is you created unique special functions.
Thanks Ted. Glad to see this diff back. I stopped pushing the diff because of zero feedback. If you don't mind, put some credit to Roman Kravchuk when you will commit, as he did most of work. I just pushed diff.
