On Sat, Mar 23, 2013 at 04:09:12PM +0100, Stefan Sperling wrote:
On Sat, Mar 23, 2013 at 09:27:50AM -0500, Vladimir Támara Patiño wrote:
> >Please change this to look like
> >in other parse.y files in the OpenBSD src tree (e.g. look at bgpd).
>
> Could you change?
No, sorry. I don't have time for doing that.
My time is also limited.
Please cross-check the parse.y files yourself and make sure the new
parse.y file follows conventions used in the existing parse.y files.
We want our source tree to be consistent.
I think it is somehow similar to lex.l and yacc.y of usr.bin/mklocale
But, however I would like to know what conventions of other parse.y files
are desirable (even for mklocale)?
* Using log.c ?
* Not using lex, but implementing the lexer in parse.y?
I see you're still tempted to copy code from FreeBSD without making
it perfect for OpenBSD. I'm not going to allow you to be that lazy ;-)
I made small changes, like improving documentation, using strlcpy
and strlcat, adding debugging of lexer when the option -d is used.
Comparing mklocale current implementations with NetBSD's, I see
improving documentation and renamings. What other conventions are
important?
Possible to show example with mklocale's lexer and parser?
Why do you compile colldef with COLLAGE_DEBUG by default?
To have the option -d that gives debuggin information (mklocale also has
it).
Don't expect me to hunt for additional opinions
and OKs before I've gotten around to review the libc changes you
sent as well, and before I'm perfectly happy with both diffs.
Ok. Better then sending both parts as one patch?
I'm certainly not going to commit any of this without asking others
for review as well, so please don't be worried if it takes some time
to get this in.
Ok.
collate.h has this:
This should be named something like COLLATE_MAX_STR_LEN.
Ok.
Also, the collate.h file has:
> +__BEGIN_DECLS
> +#ifdef COLLATE_DEBUG
> +void __collate_print_tables(void);
This is bogus. colldef.c declares and defines a collate_print_tables()
function. The __collate_print_tables() function is used in the libc
diff you sent, so it doesn't belong in the colldef diff.
Ok.
Should I sent now, only one diff (with changes for colldef, collation
tables and changes to libc ?)
--
Dios, gracias por tu amor infinito.
--
Vladimir Támara Patiño. http://vtamara.pasosdeJesus.org/
http://www.pasosdejesus.org/dominio_publico_colombia.html
