On Tue, Apr 30, 2013 at 09:51:21AM +0200, Martin Pieuchot wrote:
> On 29/04/13(Mon) 13:25, patrick keshishian wrote:
> > On Sun, Apr 28, 2013 at 03:44:09PM +0200, Martin Pieuchot wrote:
> > > Diff below is a rework of the suspend/resume logic in ehci(4).
> > > 
> > > If you're not interested in the full story below, please make sure
> > > it doesn't introduce any regression on your machine(s) and, in any
> > > case report to me (with your dmesg!) thanks :)
> > > 
> > > Full story:
> > > 
> > >   So this diff changes the way we supsend/resume ehci(4) in various
> > >   way.  It started as a simple rewrite of the ehci_reset() function
> > >   to fix a race while working on the rework of the suspend/resume
> > >   framework with deraadt@, then later on I discovered that some of
> > >   the magic in there was wrong or no longer needed.
> > >   
> > >   First of all, it removes the logic introduced in r1.46 that places
> > >   all the ports into suspend mode because it no longer makes sense
> > >   as we *do* detach/reattach USB devices during a suspend/resume 
> > >   cycle now.
> > 
> > Naive question here, but would this be a cause for issue
> > reported here:
> > 
> >     http://marc.info/?l=openbsd-misc&m=136327530312197&w=2
> 
> Certainly.
> 
> > 
> > or at least I'm curious as to why the Wacom tablet does not
> > reattach after a resume.
> 
> Really?  Are you sure it doesn't reattach or is it just not usable in
> X?  It's easy to check, try to suspend/resume in console with the
> tablet connected, does it show up again in your dmesg?

I'm pretty sure it did not, at least at the time when I posted
the original message (ref above) to misc@. As noted in that
post, the little "hey, i'm active" LED on the Wacom tablet
would not turn on after resume. However, I had some trouble
reproducing this condition since your reply. This behavior
seems USB port dependent:

$ tail -f /var/log/messages
May  2 10:51:47 noir /bsd: uhidev0 at uhub2
May  2 10:51:47 noir /bsd:  port 1 configuration 1 interface 0 "WACOM 
ET-0405-UV1.1-1" rev 1.00/1.11 addr 3
May  2 10:51:47 noir /bsd: uhidev0: iclass 3/1, 3 report ids
May  2 10:51:47 noir /bsd: uhid0 at uhidev0 reportid 2: input=7, output=0, 
feature=2
May  2 10:51:47 noir /bsd: uhid1 at uhidev0 reportid 3: input=0, output=0, 
feature=2
May  2 10:52:31 noir apmd: system resumed from APM sleep
May  2 10:52:31 noir /bsd: sd1 detached
May  2 10:52:32 noir /bsd: scsibus1 detached
May  2 10:52:32 noir /bsd: umass0 detached
May  2 10:52:32 noir /bsd: umass0 at uhub1
May  2 10:52:32 noir /bsd:  port 2 configuration 1 interface 0 "Generic 
USB2.0-CRW" rev 2.00/58.88 addr 2
May  2 10:52:32 noir /bsd: umass0: using SCSI over Bulk-Only
May  2 10:52:32 noir /bsd: scsibus1 at umass0: 2 targets, initiator 0
May  2 10:52:32 noir /bsd: sd1 at scsibus1 targ 1 lun 0: <Generic-, Multi-Card, 
1.00> SCSI0 0/direct removable serial.0bda0158114173400000
May  2 10:52:32 noir /bsd: video0 detached
May  2 10:52:32 noir /bsd: uvideo0 detached
May  2 10:52:33 noir /bsd: uvideo0 at uhub1
May  2 10:52:34 noir /bsd:  port 5 configuration 1 interface 0 "Image Processor 
Integrated Camera" rev 2.00/0.29 addr 3
May  2 10:52:34 noir /bsd: video0 at uvideo0
May  2 10:52:34 noir /bsd: uhid0 detached
May  2 10:52:34 noir /bsd: uhid1 detached
May  2 10:52:34 noir /bsd: uhidev0 detached
May  2 10:52:34 noir /bsd: uhidev0 at uhub2
May  2 10:52:34 noir /bsd:  port 1 configuration 1 interface 0 "WACOM 
ET-0405-UV1.1-1" rev 1.00/1.11 addr 3
May  2 10:52:34 noir /bsd: uhidev0: iclass 3/1, 3 report ids
May  2 10:52:34 noir /bsd: uhid0 at uhidev0 reportid 2: input=7, output=0, 
feature=2
May  2 10:52:34 noir /bsd: uhid1 at uhidev0 reportid 3: input=0, output=0, 
feature=2
May  2 10:52:34 noir /bsd: ugen0 detached
May  2 10:52:35 noir /bsd: ugen0 at uhub2
May  2 10:52:35 noir /bsd:  port 4 "Broadcom Corp Broadcom Bluetooth Device" 
rev 2.00/7.48 addr 2


Switching USB ports the Wacom is connected to:

May  2 10:52:46 noir /bsd: uhid0 detached
May  2 10:52:46 noir /bsd: uhid1 detached
May  2 10:52:46 noir /bsd: uhidev0 detached
May  2 10:52:50 noir /bsd: uhidev0 at uhub2
May  2 10:52:50 noir /bsd:  port 3 configuration 1 interface 0 "WACOM 
ET-0405-UV1.1-1" rev 1.00/1.11 addr 3
May  2 10:52:50 noir /bsd: uhidev0: iclass 3/1, 3 report ids
May  2 10:52:50 noir /bsd: uhid0 at uhidev0 reportid 2: input=7, output=0, 
feature=2
May  2 10:52:50 noir /bsd: uhid1 at uhidev0 reportid 3: input=0, output=0, 
feature=2
May  2 10:53:32 noir apmd: system resumed from APM sleep
May  2 10:53:32 noir /bsd: sd1 detached
May  2 10:53:33 noir /bsd: scsibus1 detached
May  2 10:53:33 noir /bsd: umass0 detached
May  2 10:53:33 noir /bsd: umass0 at uhub1
May  2 10:53:33 noir /bsd:  port 2 configuration 1 interface 0 "Generic 
USB2.0-CRW" rev 2.00/58.88 addr 2
May  2 10:53:33 noir /bsd: umass0: using SCSI over Bulk-Only
May  2 10:53:33 noir /bsd: scsibus1 at umass0: 2 targets, initiator 0
May  2 10:53:33 noir /bsd: sd1 at scsibus1 targ 1 lun 0: <Generic-, Multi-Card, 
1.00> SCSI0 0/direct removable serial.0bda0158114173400000
May  2 10:53:33 noir /bsd: video0 detached
May  2 10:53:33 noir /bsd: uvideo0 detached
May  2 10:53:34 noir /bsd: uvideo0 at uhub1
May  2 10:53:35 noir /bsd:  port 5 configuration 1 interface 0 "Image Processor 
Integrated Camera" rev 2.00/0.29 addr 3
May  2 10:53:35 noir /bsd: video0 at uvideo0
May  2 10:53:35 noir /bsd: uhid0 detached
May  2 10:53:35 noir /bsd: uhid1 detached
May  2 10:53:35 noir /bsd: uhidev0 detached
May  2 10:53:38 noir /bsd: uhub2: device problem, disabling port 3
May  2 10:53:38 noir /bsd: ugen0 detached
May  2 10:53:39 noir /bsd: ugen0 at uhub2
May  2 10:53:39 noir /bsd:  port 4 "Broadcom Corp Broadcom Bluetooth Device" 
rev 2.00/7.48 addr 2
^C

So, port 1 will reattach, while port 3 does not.


> And for the crash you can try to add the following in your xorg.conf:
> 
>       Section "ServerFlags"
>           Option "AllowMouseOpenFail" "True"
>       EndSection
> 
> I don't know if it will be enough, I'm not sure what's the status of
> devices hotplugging in xenocara.  If you want to be more than "curious"
> you can build the xf86-input-usbtablet with debug enable and try to find
> what the problem is ;)  Diffs are always welcome!

I have had that entry in my xorg.conf at some point in the
past. While I believe it used to prevent the crash, it no
longer seems to be effective.

Thank you for your reply.

--patrick

Reply via email to