Re: Removing -Wno-format from kernel makefiles, 4/16

[Stefan Fritsch]

On Wed, 3 Jul 2013, Mark Kettenis wrote:
> > diff --git sys/arch/i386/i386/esm.c sys/arch/i386/i386/esm.c
> > index c90b2c4..3dff69e 100644
> > --- sys/arch/i386/i386/esm.c
> > +++ sys/arch/i386/i386/esm.c
> > @@ -880,7 +880,7 @@ esm_make_sensors(struct esm_softc *sc, struct 
> > esm_devmap *devmap,
> >                     }
> >  
> >                     for (j = 0; j < nsensors; j++) {
> > -                           snprintf(s[j].desc, sizeof(s[j].desc), "%s %d",
> > +                           snprintf(s[j].desc, sizeof(s[j].desc), "%s %ld",
> >                                 sensor_map[i].name, sensor_map[i].arg + j);
> >                     }
> >                     break;
> 
> Looking at this one, it makes more sense to make the "arg" member of
> "struct esm_sensor_map" an int.  That will result in some space
> savings if we'd ever bring this driver to amd64.


--- sys/arch/i386/i386/esm.c
+++ sys/arch/i386/i386/esm.c
@@ -87,7 +87,7 @@ enum sensor_type esm_typemap[] = {
 
 struct esm_sensor_map {
        enum esm_sensor_type    type;
-       long                    arg;
+       int                     arg;
        const char              *name;
 };