On Fri, Dec 06, 2013 at 11:41:47PM -0500, Brad Smith wrote: > On 06/12/13 11:39 PM, Ted Unangst wrote: > >On Fri, Dec 06, 2013 at 20:47, Brad Smith wrote: > >>On Tue, Dec 03, 2013 at 06:48:11PM -0500, Brad Smith wrote: > >>>An unused function in the UVM code. #if 0 it out for now. > >>> > >>>uvm_map.c:171:14: error: unused function 'uvm_mapentry_freecmp' > >>[-Werror,-Wunused-function] > >>>uvm_map.c:353:1: error: unused function 'uvm_mapentry_freecmp' > >>[-Werror,-Wunused-function] > > > >I haven't looked yet to convince myself that we aren't supposed to be > >calling this function somewhere. Having an unused function isn't > >hurting us, I don't think there's a rush here. > > The function isn't being called anywhere in the tree. You're missing the > point. The kernel builds with -Werror. I wouldn't care about these > warnings if it didn't.
The kernel does not build with clang with the default flags anyway, I don't see why you can't disable some of the unwanted warnings we don't want to deal with as well when locally modifying your Makefiles.
