Your diff looks correct to me.  In the old code, we had this loop:

for (lim = mp + *mp; mp < lim;)
        if (*mp++ > *np++)
                return 1;
return 0;

Which was replaced by:

        lim = mp + *mp;
        return (memcmp(mp, np, *lim) > 0);

which is not equivalent since lim points to one byte past the end
up m_arg.  The key length is stored in the first byte so using *mp
should be correct.

 - todd

Reply via email to