On Mon, Dec 23, 2013 at 10:25, Jérémie Courrèges-Anglas wrote: > Ted Unangst <[email protected]> writes: > >> Part one of this diff eliminates a series of u_long casts in favor of >> just using native size_t types. A few other type adjustments. > > Wouldn't that make ssh harder to port to systems where those types > aren't available? See for example millert's last commit to > yacc/skeleton.c.
What are these systems? The counter argument is that using long makes the code harder to port to systems where long and ptrdiff_t are different sizes. And by harder to port, I mean compiles fine but executes incorrectly. I consider that a worse problem. If ptrdiff_t is really out, I think I'd prefer to take my chances with ssize_t being the right size. (there are 3 occurrences of ptrdiff_t in umac.c too).
