Hi All, >From NetBSD:
Fix fd leak in error cases. Found by cppcheck. Index: cmds.c =================================================================== RCS file: /cvs/src/usr.sbin/lpr/lpc/cmds.c,v Index: cmds.c =================================================================== RCS file: /cvs/src/usr.sbin/lpr/lpc/cmds.c,v retrieving revision 1.25 diff -u -p -r1.25 cmds.c --- cmds.c 24 Nov 2013 21:32:32 -0000 1.25 +++ cmds.c 29 Dec 2013 12:12:49 -0000 @@ -594,6 +594,8 @@ putmsg(int argc, char **argv) if (fd < 0 || flock(fd, LOCK_EX) < 0) { printf("\tcannot create status file\n"); PRIV_END; + if (fd >= 0) + (void)close(fd); return; } PRIV_END;