On Sun, Feb 9, 2014, at 13:56, Fabian Raetz wrote: > On Sun, Feb 09, 2014 at 09:32:15PM +0100, Mark Kettenis wrote: > > > Date: Sun, 9 Feb 2014 14:23:18 +0100 > > > From: Fabian Raetz <[email protected]> > > > > > > > > Hmm, my cleanup was based on the version you send out on December > > > > 31st. Can you send me the latest version of your diff? > > > > > > > > > > On Tue, Jan 07, 2014 at 12:08:02PM +0100, Martin Pieuchot wrote: > > > > On 03/01/14(Fri) 14:24, Fabian Raetz wrote: > > > > > Hi tech@, > > > > > > > > > > here is an updated patch. > > > > > > > > > > it seems like Intel Centrino Wireless-N 2030 and > > > > > Intel Centrino Wireless-N 2230 have the same pciids... > > > > > > > > > > this makes patch apply again with newest pcidevs changes. > > > > > > > > Please also make sure to use tab and not space when appropriate ;) You > > > > can check style(9) if in doubt ! > > > > > > > ups :) > > > attached is a diff > > > - which follows style(9) (hopefully) and > > > - fixes a firmware error by handling IWN_FW_TLV_ENH_SENS and > > > IWN_FW_TLV_PHY_CALIB in iwn_read_firmware_tlv(). > > > > > > @mike, only style changes since the last patch i send you. > > > > Thanks. I incorporated the changes in my cleaned up version. > > > > The change does affect other hardware types now, but I've tested this > > on a couple of systems: > > > > iwn0 at pci3 dev 0 function 0 "Intel WiFi Link 5300" rev 0x00: msi, MIMO > > 3T3R, MoW > > > > iwn0 at pci3 dev 0 function 0 "Intel Centrino Ultimate-N 6300" rev 0x35: > > msi, MIMO 3T3R, MoW > > > > iwn0 at pci2 dev 0 function 0 "Intel Centrino Advanced-N 6205" rev 0x34: > > msi, MIMO 2T2R, MoW > > > > So if this one works for you and Benoit, I'll go ahead and commit this. > > > works for me too. Thanks! > > iwn0 at pci2 dev 0 function 0 "Intel Centrino Wireless-N 2030" rev 0xc4: > msi, MIMO 2T2R, BGN >
Feb. 17th amd64 snapshot works for me! iwn0 at pci2 dev 0 function 0 "Intel Centrino Wireless-N 2200" rev 0xc4: msi, MIMO 2T2R, BGN Thanks -- Byron Klippert [email protected] c. 867-336-1306
