On Sun, Apr 20, 2014 at 5:06 PM, Dirk Engling <erdge...@erdgeist.org> wrote: > Dear openbsd devs, > > I've just put on my rubber gloves to help with your heroic efforts on > OpenSSL. I started to dive into OpenSSL's ASN.1 implementation and now > wonder how to share my findings, patches and requests without spamming this > list.
this list is for diffs. post them. keep them reviewable - of meaningful size and doing a certain thing. (as opposed to this diff changes 15 things.. ) > > Also while scanning through the rest of libssl, I've found an astonishing > amount of numeric literals within statements and would like to replace them > with meaningful identifiers. What's the policy here? #defines or enums? neither - if you just replace numeric literals it better be obvious you are thinking about it rather than just banally doing stuff like: #define LENGTHIKNOWNOTHINGABOUT 288 + 1 If you're doing that, you're just hiding the horror and making it harder for someone like me to fix it. Short answer - send diffs, expect criticism - not because you suck but because all diffs get criticism. If you can't handle it and improve, don't post.
