Hi tech,
there are some unread set operations in the ssh code.
Fritjof
Index: clientloop.c
===================================================================
RCS file: /cvs/src/usr.bin/ssh/clientloop.c,v
retrieving revision 1.258
diff -u -p -r1.258 clientloop.c
--- clientloop.c 2 Feb 2014 03:44:31 -0000 1.258
+++ clientloop.c 23 Apr 2014 19:50:18 -0000
@@ -934,7 +934,6 @@ process_cmdline(void)
/* XXX update list of forwards in options */
if (delete) {
- cancel_port = 0;
cancel_host = hpdelim(&s); /* may be NULL */
if (s != NULL) {
cancel_port = a2port(s);
Index: krl.c
===================================================================
RCS file: /cvs/src/usr.bin/ssh/krl.c,v
retrieving revision 1.14
diff -u -p -r1.14 krl.c
--- krl.c 31 Jan 2014 16:39:19 -0000 1.14
+++ krl.c 23 Apr 2014 19:55:50 -0000
@@ -496,7 +496,6 @@ choose_next_state(int current_state, u_i
if (cost_bitmap_restart < cost) {
new_state = KRL_SECTION_CERT_SERIAL_BITMAP;
*force_new_section = 1;
- cost = cost_bitmap_restart;
}
debug3("%s: contig %llu last_gap %llu next_gap %llu final %d,
costs:"
"list %llu range %llu bitmap %llu new bitmap %llu, "
@@ -957,7 +956,6 @@ ssh_krl_from_blob(Buffer *buf, struct ss
/* Not interested for now. */
continue;
}
- sig_seen = 1;
/* First string component is the signing key */
if ((key = key_from_blob(blob, blen)) == NULL) {
error("%s: invalid signature key", __func__);
Index: readconf.c
===================================================================
RCS file: /cvs/src/usr.bin/ssh/readconf.c,v
retrieving revision 1.219
diff -u -p -r1.219 readconf.c
--- readconf.c 23 Apr 2014 12:42:34 -0000 1.219
+++ readconf.c 23 Apr 2014 20:01:26 -0000
@@ -1255,7 +1255,7 @@ parse_int:
if (!arg || *arg == '\0')
fatal("%.200s line %d: Missing ControlPersist"
" argument.", filename, linenum);
- value = 0;
+
value2 = 0; /* timeout */
if (strcmp(arg, "no") == 0 || strcmp(arg, "false") == 0)
value = 0;
Index: scp.c
===================================================================
RCS file: /cvs/src/usr.bin/ssh/scp.c,v
retrieving revision 1.179
diff -u -p -r1.179 scp.c
--- scp.c 20 Nov 2013 20:53:10 -0000 1.179
+++ scp.c 23 Apr 2014 20:05:22 -0000
@@ -818,7 +818,6 @@ next: if (fd != -1) {
if (fd != -1) {
if (close(fd) < 0 && !haderr)
haderr = errno;
- fd = -1;
}
if (!haderr)
(void) atomicio(vwrite, remout, "", 1);
Index: sftp.c
===================================================================
RCS file: /cvs/src/usr.bin/ssh/sftp.c,v
retrieving revision 1.160
diff -u -p -r1.160 sftp.c
--- sftp.c 22 Apr 2014 10:07:12 -0000 1.160
+++ sftp.c 23 Apr 2014 20:11:54 -0000
@@ -1222,7 +1222,6 @@ parse_args(const char **cpp, int *ignore
*aflag = *fflag = *hflag = *iflag = *lflag = *pflag = 0;
*rflag = *sflag = 0;
*path1 = *path2 = NULL;
- optidx = 1;
switch (cmdnum) {
case I_GET:
case I_REGET:
