Hello,

is there a reason why file system fragments are called "blocks" instead of "frags" in comments in sys/ufs/ffs/fs.h sometime?

The patch below treats only occurrence.


Index: src/sys/ufs/ffs/fs.h
===================================================================
RCS file: /cvs/src/sys/ufs/ffs/fs.h,v
retrieving revision 1.39
diff -u -p -u -r1.39 fs.h
--- src/sys/ufs/ffs/fs.h        12 Nov 2013 14:20:52 -0000      1.39
+++ src/sys/ufs/ffs/fs.h        26 Apr 2014 16:37:06 -0000
@@ -272,7 +272,7 @@ struct fs {
        int64_t  fs_sblockloc;          /* offset of standard super block */
        struct  csum_total fs_cstotal;  /* cylinder summary information */
        int64_t  fs_time;               /* time last written */
-       int64_t  fs_size;               /* number of blocks in fs */
+       int64_t  fs_size;               /* number of frags in fs */
        int64_t  fs_dsize;              /* number of data blocks in fs */
        int64_t  fs_csaddr;             /* blk addr of cyl grp summary area */
        int64_t  fs_pendingblocks;      /* blocks in process of being freed */


- OR - another variant, which is more consistent with fs_ffs1_size description and others. Which of the two, if any, is better? Thank you.


Index: src/sys/ufs/ffs/fs.h
===================================================================
RCS file: /cvs/src/sys/ufs/ffs/fs.h,v
retrieving revision 1.39
diff -u -p -u -r1.39 fs.h
--- src/sys/ufs/ffs/fs.h        12 Nov 2013 14:20:52 -0000      1.39
+++ src/sys/ufs/ffs/fs.h        26 Apr 2014 16:35:40 -0000
@@ -272,7 +272,7 @@ struct fs {
        int64_t  fs_sblockloc;          /* offset of standard super block */
        struct  csum_total fs_cstotal;  /* cylinder summary information */
        int64_t  fs_time;               /* time last written */
-       int64_t  fs_size;               /* number of blocks in fs */
+       int64_t  fs_size;               /* number of blocks in fs / frags */
        int64_t  fs_dsize;              /* number of data blocks in fs */
        int64_t  fs_csaddr;             /* blk addr of cyl grp summary area */
        int64_t  fs_pendingblocks;      /* blocks in process of being freed */



Regards,
David

Reply via email to