On Sat, Apr 26, 2014 at 05:36:45PM +0200, Florian Riehm wrote: > our IGMP packets don't contain router alert options. > According rfc 2236 (Internet Group Management Protocol, Version 2) > packets without this option have to be ignored. Some layer 3 switches > are blocking our igmp packets because of that. > The following patch is based on a FreeBSD patch long years ago: > http://svnweb.freebsd.org/base?view=revision&revision=14622
> /* > * To avoid byte-swapping the same value over and over again. > */ FreeBSD has code matching this comment. In OpenBSD the code is gone and so should the comment. Of course that is unrelated to this diff. > + /* > + * Construct a Router Alert option to use in outgoing packets > + */ The * must be aligned. > + ra->ipopt_dst.s_addr = 0; Use INADDR_ANY instead of 0 as it is an IP address. Otherwise OK bluhm@
