On 06/05/14(Tue) 13:44, Jérémie Courrèges-Anglas wrote:
> Martin Pieuchot <[email protected]> writes:
>
> > Plug a memory leak related to HID descriptor parsing, ok?
>
> I don't have any ums(4) device but this is obviously right, so ok.
>
> I've found this useless check during review:
That's correct and ok mpi@, but could you please wait a bit before
committing it, this will conflict with my HID parser diff.
> Index: hid.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/hid.c,v
> retrieving revision 1.25
> diff -u -p -p -u -r1.25 hid.c
> --- hid.c 5 Aug 2012 16:07:11 -0000 1.25
> +++ hid.c 6 May 2014 11:43:07 -0000
> @@ -458,8 +458,6 @@ hid_is_collection(void *desc, int size,
> u_int32_t coll_usage = ~0;
>
> hd = hid_start_parse(desc, size, hid_none);
> - if (hd == NULL)
> - return (0);
>
> DPRINTFN(2,("hid_is_collection: id=%d usage=0x%x\n", id, usage));
> while (hid_get_item(hd, &hi)) {
>
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
