On Wed, May 21, 2014 at 4:12 PM, Stefan Sperling <s...@openbsd.org> wrote: > On Wed, May 21, 2014 at 02:20:08PM +0200, David Coppa wrote: >> >> Hi! >> >> Found this while analyzing rxvt-unicode's config.log: >> >> configure:7078: checking for working X setlocale >> configure:7095: c++ -o conftest -O2 -pipe -w -I/usr/X11R6/include >> conftest.cpp -lsupc++ -L/usr/X11R6/lib -R/usr/X11R6/lib -lX11 >&5 >> /tmp//cc2K0U3P.o(.text+0x11): In function `main': >> : undefined reference to `_Xsetlocale' >> collect2: ld returned 1 exit status >> configure:7095: $? = 1 >> configure: failed program was: >> >> The diff below makes Xsetlocale fall back to setlocale() like they >> did for Apple and Cygwin... >> >> Opinions / OKs ? > > In my mind, this raises a couple of questions I don't know any answers to. > > What's the impact of this change on rxvt-unicode? > > http://permalink.gmane.org/gmane.comp.freedesktop.xorg.devel/2556 > What does "proper locale support" mean to them? > Does our setlocale() qualify? It returns errors for most things except > LC_CTYPE and LC_MESSAGES, which wouldn't happen on most other systems. > > What do applications expect from _Xsetlocale? How is this API used?
Something is still wrong btw... Our libX11 has Xlocale support (it's not compiled using --disable-xlocale and /usr/X11R6/include/X11/Xlocale.h is there). Yet, if you try to use the _Xsetlocale function, it fails with the error above. My patch is the less instrusive thing I could think of... cheers! David
