So, in r1.40 the comment was corrected to reflect that this was fixed in
3.7, but the actual check still only checked up to 3.5.

http://www.openbsd.org/cgi-bin/cvsweb/src/gnu/usr.bin/perl/hints/openbsd.sh.diff?r1=1.39;r2=1.40;f=h

And then r1.1.1.8 was created with the correct version in the check,
but an incorrect comment.

http://www.openbsd.org/cgi-bin/cvsweb/src/gnu/usr.bin/perl/hints/openbsd.sh.diff?r1=1.1.1.7;r2=1.1.1.8;f=h

r1.45 brings it back the correct comment, but unfortunately the
incorrect check.

http://www.openbsd.org/cgi-bin/cvsweb/src/gnu/usr.bin/perl/hints/openbsd.sh.diff?r1=1.44;r2=1.45;f=h

This brings back the correct version of the check and leaves the
reasonable comment.

I will be sending this patch upstream when it makes more sense.

https://github.com/afresh1/OpenBSD-perl/blob/master/patches/GOOD/UPSTREAM/correct_versions_in_hints.patch

OK?
Index: gnu/usr.bin/perl/hints/openbsd.sh
===================================================================
RCS file: /cvs/src/gnu/usr.bin/perl/hints/openbsd.sh,v
retrieving revision 1.51
diff -u -p -u -r1.51 openbsd.sh
--- gnu/usr.bin/perl/hints/openbsd.sh   31 May 2014 23:16:21 -0000      1.51
+++ gnu/usr.bin/perl/hints/openbsd.sh   1 Jun 2014 00:24:17 -0000
@@ -118,7 +118,7 @@ $define|true|[yY]*)
        ;;
        esac
        case "$osvers" in
-       [012].*|3.[0-5])
+       [012].*|3.[0-6])
                # Broken up to OpenBSD 3.6, fixed in OpenBSD 3.7
                d_getservbyname_r=$undef ;;
        esac

Reply via email to