On 12 June 2014 15:59, Christian Weisgerber <na...@mips.inka.de> wrote: > Ted Unangst: > >> > -int blockswritten; /* number of blocks written on current tape */ >> > +off_t blockswritten; /* number of blocks written on current tape */ >> > time_t tstart_writing; /* when started writing the first tape block */ >> > long xferrate; /* averaged transfer rate of all volumes */ >> >> I'm not sure off_t is the right semantic type. Perhaps just use int64_t? > > I picked off_t for consistency with tapesize, but we could use > int64_t for both. Not sure about the other off_t's there either. > >> (And maybe change xferrate? I'm not sure why that needs to change size >> based on machine, and I can probably assemble an i386 system capable >> of wrapping it. int64_t again.) > > I can't get more than 66 MB/s out of my system, so good luck breaking > 2 TB/s now, but yes, we can proactively fix that. > > -- > Christian "naddy" Weisgerber na...@mips.inka.de >
I would go with int64_t for blockswritten and anything else that is counting anything other that characters. .... Ken
