* Kent R. Spillner <kspill...@acm.org> [2014-07-10 20:47]: > I saw this was already committed, but one tiny consistency nit inline below.
I'd argue it's not consistency, rather the opposite, since: > > - mh.mh_len = 4; > > + bpf_mtap_hdr(arg, (caddr_t)&afh, 4, m, direction, NULL); you see this was very mechanic. however: > I realize this is kind of obvious because afh is declared immediately before > this, but to me that 4 looks out of place. Perhaps sizeof(afh) would be > better? I could not agree more. i'll commit it as soon as I find a tree in my forest that has a clean bpf.c :o -- Henning Brauer, h...@bsws.de, henn...@openbsd.org BS Web Services GmbH, http://bsws.de, Full-Service ISP Secure Hosting, Mail and DNS. Virtual & Dedicated Servers, Root to Fully Managed Henning Brauer Consulting, http://henningbrauer.com/
