The C standard mandates that static be first.
>From ISO/IEC 9899:1999 and 9899:201x,
6.11.5 - Storage-class specifiers:
The placement of a storage-class specifier other than at the
beginning of the declaration specifiers in a declaration is
an obsolescent feature.
and -Wextra complains:
warning: 'static' is not at beginning of declaration
Index: sys/crypto/sha2.c
===================================================================
RCS file: /cvs/src/sys/crypto/sha2.c,v
retrieving revision 1.8
diff -u -p -r1.8 sha2.c
--- sys/crypto/sha2.c 11 Jan 2011 15:42:05 -0000 1.8
+++ sys/crypto/sha2.c 14 Jul 2014 15:31:53 -0000
@@ -167,7 +167,7 @@ void SHA512Transform(SHA2_CTX *, const u
/*** SHA-XYZ INITIAL HASH VALUES AND CONSTANTS ************************/
/* Hash constant words K for SHA-256: */
-const static u_int32_t K256[64] = {
+static const u_int32_t K256[64] = {
0x428a2f98UL, 0x71374491UL, 0xb5c0fbcfUL, 0xe9b5dba5UL,
0x3956c25bUL, 0x59f111f1UL, 0x923f82a4UL, 0xab1c5ed5UL,
0xd807aa98UL, 0x12835b01UL, 0x243185beUL, 0x550c7dc3UL,
@@ -187,7 +187,7 @@ const static u_int32_t K256[64] = {
};
/* Initial hash value H for SHA-256: */
-const static u_int32_t sha256_initial_hash_value[8] = {
+static const u_int32_t sha256_initial_hash_value[8] = {
0x6a09e667UL,
0xbb67ae85UL,
0x3c6ef372UL,
@@ -199,7 +199,7 @@ const static u_int32_t sha256_initial_ha
};
/* Hash constant words K for SHA-384 and SHA-512: */
-const static u_int64_t K512[80] = {
+static const u_int64_t K512[80] = {
0x428a2f98d728ae22ULL, 0x7137449123ef65cdULL,
0xb5c0fbcfec4d3b2fULL, 0xe9b5dba58189dbbcULL,
0x3956c25bf348b538ULL, 0x59f111f1b605d019ULL,
@@ -243,7 +243,7 @@ const static u_int64_t K512[80] = {
};
/* Initial hash value H for SHA-384 */
-const static u_int64_t sha384_initial_hash_value[8] = {
+static const u_int64_t sha384_initial_hash_value[8] = {
0xcbbb9d5dc1059ed8ULL,
0x629a292a367cd507ULL,
0x9159015a3070dd17ULL,
@@ -255,7 +255,7 @@ const static u_int64_t sha384_initial_ha
};
/* Initial hash value H for SHA-512 */
-const static u_int64_t sha512_initial_hash_value[8] = {
+static const u_int64_t sha512_initial_hash_value[8] = {
0x6a09e667f3bcc908ULL,
0xbb67ae8584caa73bULL,
0x3c6ef372fe94f82bULL,
Index: lib/libc/crypt/bcrypt.c
===================================================================
RCS file: /cvs/src/lib/libc/crypt/bcrypt.c,v
retrieving revision 1.44
diff -u -p -r1.44 bcrypt.c
--- lib/libc/crypt/bcrypt.c 17 May 2014 15:18:06 -0000 1.44
+++ lib/libc/crypt/bcrypt.c 14 Jul 2014 15:31:53 -0000
@@ -231,10 +231,10 @@ bcrypt_checkpass(const char *pass, const
/*
* internal utilities
*/
-const static u_int8_t Base64Code[] =
+static const u_int8_t Base64Code[] =
"./ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
-const static u_int8_t index_64[128] = {
+static const u_int8_t index_64[128] = {
255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
255, 255, 255, 255, 255, 255, 255, 255, 255, 255,
Index: lib/libc/net/res_random.c
===================================================================
RCS file: /cvs/src/lib/libc/net/res_random.c,v
retrieving revision 1.20
diff -u -p -r1.20 res_random.c
--- lib/libc/net/res_random.c 12 Nov 2013 07:00:24 -0000 1.20
+++ lib/libc/net/res_random.c 14 Jul 2014 15:31:53 -0000
@@ -87,7 +87,7 @@ struct prf_ctx {
};
#define PFAC_N 3
-const static u_int16_t pfacts[PFAC_N] = {
+static const u_int16_t pfacts[PFAC_N] = {
2,
3,
2729
