Hi Reyk told me about this and apologies for it. I am fixing it at the moment. Thanks for prompt feedback though.
Kind regards. On 10 August 2014 14:19, Jérémie Courrèges-Anglas <[email protected]> wrote: > David Carlier <[email protected]> writes: > > > Hi all. > > > > I ve made a first draft of a new geolocalization service available here > > https://github.com/devnexen/geoloc > > > > which can be used by some other daemons. In short terms, it can gives > > geolocalization informations (country code, isp...) from an ip address. > > > > Feel free to give some thoughts about it. > > The code looks sane. > > However I have a big problem with the code you are publishing. Only > log.c retains the copyright and licence header from the original file. > In parse.y you removed the original copyright notices, adding > > Copyright (c) 2014 DeviceAtlas Tech <[email protected]> > > That's clearly a very wrong approach. You can not remove a copyright > notice unless you can prove that the file no longer contains code > written by that copyright holder. I suspect that control.c should have > copyright notices from other authors too, it's up to you to decide which > other files are concerned. geolocd(8) still mentions ripd(8) and should > still be improved; geolocd.conf.5 is unfinished and contains lot of > irrelevant but non-trivial content, while the copyright notice has been > replaced too. > > I suggest that you solve those issues, by being honest about the code > you've written, and about the code you've copied. They matter a lot to > the OpenBSD project as a whole. Do what you want with it, but don't say > that you wrote it. > > -- > jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE >
