Hi Dmitry, Thank you for working on this. You will probably get a more thorough review once folks start coming back from summer vacation, but here is my initial take:
The coding style looks good. There are a few #if 0's that probably don't need to be there, but that's minor. The regress tests seem to still have echos from when GOST was built as a engine and could probably be simplified. We could probably apply the first generic 3 patches independently from the rest of the series. They look fine to me. On Mon, Aug 11, 2014 at 10:56 PM, Dmitry Eremin-Solenikov < dbarysh...@gmail.com> wrote: > Hello, > > I have updated the GOST cipher suites implementation at > https://github.com/libressl-portable/openbsd/pull/6 . > It is nearly done (only few FIXMEs remaining), so I'd like > to try to receive at least some kind of review. > > -- > With best wishes > Dmitry > >
