On Fri, Aug 15, 2014 at 09:35:03PM +0400, Vadim Zhukov wrote:
> The SIOCG80211ALLNODES operate on struct ieee80211_nodereq_all, not
> on struct ieee80211_nodereq, right? If I understand things correctly,
> we were on a safe side because struct ieee80211_nodereq is larger
> than struct ieee80211_nodereq_all.  Should this follow some bump? OK?
> 

OK, but remove the XXX comment ;)

> --
> WBR,
>   Vadim Zhukov
> 
> Index: ieee80211_ioctl.h
> ===================================================================
> RCS file: /cvs/src/sys/net80211/ieee80211_ioctl.h,v
> retrieving revision 1.19
> diff -u -p -r1.19 ieee80211_ioctl.h
> --- ieee80211_ioctl.h 10 Jul 2014 14:32:28 -0000      1.19
> +++ ieee80211_ioctl.h 15 Aug 2014 17:32:24 -0000
> @@ -348,7 +348,8 @@ struct ieee80211_nodereq_all {
>       u_int8_t                        na_flags;       /* IEEE80211_NODEREQ_* 
> */
>  };
>  
> -#define SIOCG80211ALLNODES   _IOWR('i', 214, struct ieee80211_nodereq)
> +/* XXX typo, should be ieee80211_nodereq_all instead? */
> +#define SIOCG80211ALLNODES   _IOWR('i', 214, struct ieee80211_nodereq_all)
>  
>  /* net80211 specific interface flags */
>  #define IEEE80211_F_HIDENWID 0x10000000      /* CONF: hidden ssid mode */
> 

-- 

Reply via email to