pcppi.c indirectly includes sys/timeout.h by
including dev/ic/pckbcvar.h

Are you building a kernel without ukbd(4) and pckbd(4)?

I'll add the include, I'm just curious why it seems to break for you.

On Sat, Sep 20, 2014 at 01:17:15PM -0400, Atticus wrote:
> It failed compiling on i386 for me. I didn't get around to trying amd64.
> It's possible that my source tree
> was buggered up somehow, but since that was the only error, I don't think
> that's very likely.
> 
> On Sat, Sep 20, 2014 at 3:51 AM, Jonathan Gray <j...@jsg.id.au> wrote:
> 
> > Seems reasonable given the file uses timeouts, but it
> > compiles fine at the moment on i386.  Which platform
> > requires this?
> >
> > On Sat, Sep 20, 2014 at 03:00:20AM -0400, Atticus wrote:
> > > Revision 1.11 of pcppi.c is missing an include for sys/timeout.h, without
> > > which leaves sc_bell_timeout without a type, breaking it. Patch is below.
> > >
> > > diff -u -r1.11 pcppi.c
> > > --- pcppi.c     14 Sep 2014 14:17:25 -0000      1.11
> > > +++ pcppi.c     20 Sep 2014 06:56:13 -0000
> > > @@ -33,6 +33,7 @@
> > >  #include <sys/kernel.h>
> > >  #include <sys/device.h>
> > >  #include <sys/errno.h>
> > > +#include <sys/timeout.h>
> > >
> > >  #include <machine/bus.h>
> > >
> > > --
> > > FT2(SS) Byron Grobe, USN
> > > USS Providence (SSN-719)
> >
> >
> 
> 
> -- 
> FT2(SS) Byron Grobe, USN
> USS Providence (SSN-719)

Reply via email to