On Mon, Sep 22, 2014 at 06:48:49PM +0200, Raphael Graf wrote:
>
> I'm sorry, this diff was using the wrong defines.
> Here's a corrected version.
>
> Any comments or oks?
>
> +
> + if (sectors != 0) {
> + sf->flags |= SFF_SDHC;
> + sf->csd.capacity = sectors;
> }
I think I'd prefer to see the 2G test back here that the original diff
had. As the emmc spec says that sector addressing is only for > 2G.
"The lowest common nominator, 2GB in this case, will set the limit. The
implementation of a higher than 2GB of density of memory will not be
backwards compatible with the lower densities. First of all the address
argument for higher than 2GB of density of memory is changed to be
sector address (512B sectors) instead of byte address. Secondly the
density of the card is read from the EXT_CSD register instead of CSD
register."
And though I don't have any emmc using devices here the diff
otherwise looks good, so OK.
