On 09/10/14(Thu) 22:58, Jonathan Armani wrote:
> Hi,
>
> Diff add my Logitech Webcam C310 to usbdevs.
>
> Bus 000 Device 003: ID 046d:081b Logitech, Inc. Webcam C310
What do you see in your dmesg when you don't have this entry in usbdevs?
Is it understandable?
I'm asking, because generally USB device names can be read from the
device descriptor. My point is that, if you don't need to use this
define to whitelist a specific device in a driver, adding it to the
list just makes the kernel bigger.
Since most of the devices attaching to uvideo(4) are matched by
interface, I think that we should simply remove the unused defines of
the Webcams: there's no point in maintaining an unmaintainable list :)
> Index: usbdevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/usbdevs,v
> retrieving revision 1.637
> diff -u -p -r1.637 usbdevs
> --- usbdevs 5 Oct 2014 08:32:39 -0000 1.637
> +++ usbdevs 9 Oct 2014 20:56:21 -0000
> @@ -2493,6 +2493,7 @@ product LOGITECH QUICKCAMWEB 0x0801 Quic
> product LOGITECH WEBCAMC200 0x0802 Webcam C200
> product LOGITECH WEBCAMC500 0x0807 Webcam C500
> product LOGITECH QUICKCAMPRO 0x0810 QuickCam Pro
> +product LOGITECH WEBCAMC310 0x081b Webcam C310
> product LOGITECH HDPROC910 0x0821 HD Pro Webcam C910
> product LOGITECH QUICKCAMEXP 0x0840 QuickCam Express
> product LOGITECH QUICKCAM 0x0850 QuickCam
> Index: usbdevs.h
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/usbdevs.h,v
> retrieving revision 1.649
> diff -u -p -r1.649 usbdevs.h
> --- usbdevs.h 5 Oct 2014 08:33:13 -0000 1.649
> +++ usbdevs.h 9 Oct 2014 20:56:23 -0000
> @@ -1,4 +1,4 @@
> -/* $OpenBSD: usbdevs.h,v 1.649 2014/10/05 08:33:13 mpi Exp $ */
> +/* $OpenBSD$ */
>
> /*
> * THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT.
> @@ -2500,6 +2500,7 @@
> #define USB_PRODUCT_LOGITECH_WEBCAMC200 0x0802 /* Webcam C200
> */
> #define USB_PRODUCT_LOGITECH_WEBCAMC500 0x0807 /* Webcam C500
> */
> #define USB_PRODUCT_LOGITECH_QUICKCAMPRO 0x0810 /*
> QuickCam Pro */
> +#define USB_PRODUCT_LOGITECH_WEBCAMC310 0x081b /* Webcam C310
> */
> #define USB_PRODUCT_LOGITECH_HDPROC910 0x0821 /* HD Pro
> Webcam C910 */
> #define USB_PRODUCT_LOGITECH_QUICKCAMEXP 0x0840 /*
> QuickCam Express */
> #define USB_PRODUCT_LOGITECH_QUICKCAM 0x0850 /* QuickCam */
> Index: usbdevs_data.h
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/usbdevs_data.h,v
> retrieving revision 1.643
> diff -u -p -r1.643 usbdevs_data.h
> --- usbdevs_data.h 5 Oct 2014 08:33:13 -0000 1.643
> +++ usbdevs_data.h 9 Oct 2014 20:56:25 -0000
> @@ -1,4 +1,4 @@
> -/* $OpenBSD: usbdevs_data.h,v 1.643 2014/10/05 08:33:13 mpi Exp $ */
> +/* $OpenBSD$ */
>
> /*
> * THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT.
> @@ -5488,6 +5488,10 @@ const struct usb_known_product usb_known
> {
> USB_VENDOR_LOGITECH, USB_PRODUCT_LOGITECH_QUICKCAMPRO,
> "QuickCam Pro",
> + },
> + {
> + USB_VENDOR_LOGITECH, USB_PRODUCT_LOGITECH_WEBCAMC310,
> + "Webcam C310",
> },
> {
> USB_VENDOR_LOGITECH, USB_PRODUCT_LOGITECH_HDPROC910,
>
