On 28 October 2014 17:02, Ted Unangst <t...@tedunangst.com> wrote: > On Tue, Oct 28, 2014 at 16:49, David Gwynne wrote: >> when i shuffled the locking in pools around, page colouring was >> left behind. >> >> page colouring is where you offset items within a page if you have >> enough slack space. the previous implementation simply incremented >> the colour so each new page got the next offset. i didnt do this >> because the page and its items are now initted outside the lock, >> so maintaining that curcolour iterator wasnt as easy. >> >> this sidesteps the curcolor maintenance by just having each page >> randomly pick a colour when it's set up. > > Would it make more sense to use the page address to pick the color? >
Does it actually still make sense to keep page coloring? Is there still benefit on modern hardware?
